[
https://issues.apache.org/jira/browse/BOOKKEEPER-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686522#comment-13686522
]
Ivan Kelly commented on BOOKKEEPER-613:
---------------------------------------
{quote}one question, if you are adding a total different ledger storage, it
makes sense to put the interleaved ledger storage into a sub package. but since
the skip list ledger storage is based on interleaved ledger storage, I don't
see the value of doing this refactor now.{quote}
Currently, the journal, the storage, the sync thread and a load of utility
classes are in the one package. The storage consists of many classes. The value
of this patch is moving them into their own package, so that it's clear which
classes belong to storage. The whether we have o.a.b.bookie.storage &
o.a.b.bookie.storage.sls or o.a.b.bookie.ills & o.a.b.bookie.sls makes no
difference to me. Really the aim is to separate them logically, so that it is
clearer what belongs to storage, and consequently, what needs to be tested for
storage.
{quote}since we had bunch of patches is based on current package
structure{quote}
I assume you mean in the twitter github? These will need to be manually merged
anyhow due to other changes (such as the checkpointing).
tbh, I don't mind which we do first, but not having this change in will mean
differing adding testing for BOOKKEEPER-432. I'm ok with this as long as a
testing jira for BOOKKEEPER-432 becomes a blocker for the 4.3.0 release.
> Prep codebase for new ledger storage
> ------------------------------------
>
> Key: BOOKKEEPER-613
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-613
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-613-Prep-codebase-for-new-ledger-storage.patch
>
>
> Currently all the code for interleaved ledger storage is in the bookie
> package. Likewise, the tests are in the bookie package. This makes it unclear
> what is a test of the ledger storage and what is a test of the bookie in
> general.
> This JIRA is to move both of these into a subpackage of bookie,
> o.a.b.bookie.ills. BOOKKEEPER-432 will then go into o.a.b.bookie.sls, and
> each of the tests in the ills package will have a corresponding test in sls.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
