[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982848#comment-13982848
 ] 

Rakesh R commented on BOOKKEEPER-749:
-------------------------------------

Hi [~ikelly], [~fpj],
I've attached initial draft patch where I've introduced two new interfaces in 
LedgerUnderreplicationManager:
- Iterator<String> getUrLedgers(GenericCallback<Void> cb)
- long tryLockLedgerToRereplicate(String urLedger, final GenericCallback<Void> 
cb)

If we agrees on these interfaces, I'll add testcases and remove the existing 
api #getLedgerToRereplicate() too. Then later the same can be used by 
BOOKKEEPER-733

Thanks,
Rakesh

> Improve LedgerUnderreplicationManager#getLedgerToRereplicate()
> --------------------------------------------------------------
>
>                 Key: BOOKKEEPER-749
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-749
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-auto-recovery
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: 00001-BOOKKEEPER-749-interface.patch
>
>
> As per the discussion in BOOKKEEPER-733, 
> LedgerUnderreplicationManager#getLedgerToRereplicate having multiple 
> resposibilities like : getUrLedger + acquireLock. Actually the idea of this 
> JIRA is to make the interface better.
> Please see the discussion thread:
> https://issues.apache.org/jira/browse/BOOKKEEPER-733?focusedCommentId=13963072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13963072



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to