[
https://issues.apache.org/jira/browse/BOOKKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982998#comment-13982998
]
Rakesh R commented on BOOKKEEPER-749:
-------------------------------------
bq.What's the reason for having a base interface?
Instead of notifyUnderreplicationChange() and notifyLockStatusChange() flat
structure, I thought of seeing in a hierarchy. Feel free to choose good one:)
bq.Usually, the notification should carry some context information also.
In this case, there is no relevance of context information instead for us its a
trigger point to enter into next iteration/cycle by calling
LedgerUnderreplicationManager#listLedgersToReplicate() to get the possible
items. But we can build context info like, UrChange will have its children and
urLockStatus will have the urLedger which was attempted to lock.
LedgerUrListener<T>#notify(T t)
> Improve LedgerUnderreplicationManager#getLedgerToRereplicate()
> --------------------------------------------------------------
>
> Key: BOOKKEEPER-749
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-749
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-auto-recovery
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: 00001-BOOKKEEPER-749-interface.patch
>
>
> As per the discussion in BOOKKEEPER-733,
> LedgerUnderreplicationManager#getLedgerToRereplicate having multiple
> resposibilities like : getUrLedger + acquireLock. Actually the idea of this
> JIRA is to make the interface better.
> Please see the discussion thread:
> https://issues.apache.org/jira/browse/BOOKKEEPER-733?focusedCommentId=13963072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13963072
--
This message was sent by Atlassian JIRA
(v6.2#6252)
