[
https://issues.apache.org/jira/browse/BOOKKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991546#comment-13991546
]
Sijie Guo commented on BOOKKEEPER-747:
--------------------------------------
the patch looks good. [~fpj] you might need to address [~rakeshr]'s 1) & 3)
comments, although I don't know why the patch passed trailing spaces checking.
for 1), you might need to consider fix the synchronization on listenerSet on
AbstractZkLedgerManager.
[~rakeshr] your 2nd comment isn't valid, since it is not a thread.
> Implement register/unregister LedgerMetadataListener in MSLedgerManagerFactory
> ------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-747
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-747
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.3.0, 4.2.3
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.3.0, 4.2.3
>
> Attachments: BOOKKEEPER-747-4.2.patch, BOOKKEEPER-747.patch,
> BOOKKEEPER-747.patch, BOOKKEEPER-747.patch
>
>
> Check TODOs in MSLedgerManagerFactory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
