[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134041#comment-14134041
]
Ivan Kelly commented on BOOKKEEPER-782:
---------------------------------------
Patch looks good. Minor comment. Why no return the builder from parse() so that
you don't need to construct a new builder to set the znode version. Also, the
default znodeVersion shouldn't be -1, as this means "any version" to zookeeper.
Some other negative number would do. And this should be defined in a constant
also.
> Use builder pattern for Cookie
> ------------------------------
>
> Key: BOOKKEEPER-782
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch,
> BOOKKEEPER-782.patch
>
>
> It would be good to use builder pattern for Cookie, rather than modifying the
> fields in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
