[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136000#comment-14136000
]
Rakesh R commented on BOOKKEEPER-782:
-------------------------------------
Attached another patch
- used #generateCookie(String instanceId).
- modified the constructors
bq.for bookie id, you should just get back the builder somehow, set it on the
builder, and build(). it's simpler since this is only exercised from the
conversion tool, not from a bookie itself.
I'm thinking to have an overloaded method #generateCookie(BookieSocketAddress
addr). Does this sounds good to you?
> Use builder pattern for Cookie
> ------------------------------
>
> Key: BOOKKEEPER-782
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch,
> BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, BOOKKEEPER-782.patch
>
>
> It would be good to use builder pattern for Cookie, rather than modifying the
> fields in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
