[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136861#comment-14136861
 ] 

Rakesh R commented on BOOKKEEPER-782:
-------------------------------------

bq.what you suggested before should be ok. why you don't use it?
Hi [[email protected]], you had previously commented out to use 
[generateCookie 
method|https://issues.apache.org/jira/browse/BOOKKEEPER-782?focusedCommentId=14135287&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14135287].
 Do you agree by directly using the builder outside. I also feel external 
entities can access this way and re-build it with new values.

> Use builder pattern for Cookie
> ------------------------------
>
>                 Key: BOOKKEEPER-782
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, 
> BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, BOOKKEEPER-782.patch
>
>
> It would be good to use builder pattern for Cookie, rather than modifying the 
> fields in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to