[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151699#comment-14151699
]
Ivan Kelly commented on BOOKKEEPER-773:
---------------------------------------
New patch looks to me. +1 committing.
One comment (though it's not worth holding up the patch for). In
UpdateCookieCmd#updateBookieIdInCookie is would be clearer to pass two objects,
oldConf and newConf, so that you don't have to keep changing the configuration
each time, and so that's it's clear which configuration each operation is being
performed with. This is easier said than done though. The ServerConfiguration
constructor that takes another ServerConfiguration as an argument doesn't
actually copy the keyvalues from the other configuration. So changes on the new
conf will also change on the old conf. This is ugly, but seems very hard to
fix. Using AbstractConfiguration#append() breaks some another tests. Using
AbstractConfiguration#copy() breaks everything. It's really quite annoying. Not
something we need to tackle now though.
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch,
> 006-BOOKKEEPER-773-rename-bookieid.patch,
> 007-BOOKKEEPER-773-rename-bookieid.patch,
> 008-BOOKKEEPER-773-rename-bookieid.patch,
> 009-BOOKKEEPER-773-rename-bookieid.patch,
> 010-BOOKKEEPER-773-rename-bookieid.patch,
> 011-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
