On 5/4/20 7:20 PM, Grant Likely wrote:
> None of the relevent specs (EFI, DT, EBBR) specify the GUID for passing
> a DTB. Add it to the EBBR document so it is documented somewhere
> relevant.
>
> Fixes: #45
> Cc: Andrei Warkentin <awarken...@vmware.com>
> Cc: Francois Ozog <francois.o...@linaro.org>
> Signed-off-by: Grant Likely <grant.lik...@arm.com>
> ---
>  source/chapter2-uefi.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/source/chapter2-uefi.rst b/source/chapter2-uefi.rst
> index f6a5802..cf2f652 100644
> --- a/source/chapter2-uefi.rst
> +++ b/source/chapter2-uefi.rst
> @@ -86,6 +86,16 @@ tables.
>  - An Advanced Configuration and Power Interface [ACPI]_ table, or
>  - a Devicetree [DTSPEC]_ system description
>
> +A Devicetree system description MUST be provided in Flattened Devicetree 
> (DTB)
> +format version 17 or higher.

It is not self-evident what format version 17 might refer to.

I would suggest :

A Devicetree system description MUST be provided in Flattened Device
Tree (DTB) format version 17 (described in Devicetree Specification 0.2)
or higher.

> +The following GUID must be used in the EFT system table to identify the DTB.

I would not know what EFT refers to. I cannot find that term in the UEFI
spec. And it is not used in EBBR version 1.0. I suggest:

The configuration table with the Flattened Devicetree is identified by
the following GUID in the UEFI system table:

Best regards

Heinrich

> +
> +.. code-block:: c
> +
> +    #define EFI_DTB_GUID \
> +         EFI_GUID(0xb1b621d5, 0xf19c, 0x41a5, \
> +                  0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0)
> +
>  As stated above, EBBR systems must not provide both ACPI and Devicetree
>  tables at the same time.
>  Systems that support both interfaces must provide a configuration
> --
> 2.20.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose the 
> contents to any other person, use it for any purpose, or store or copy the 
> information in any medium. Thank you.
> _______________________________________________
> boot-architecture mailing list
> boot-architecture@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/boot-architecture
>

_______________________________________________
boot-architecture mailing list
boot-architecture@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/boot-architecture

Reply via email to