>>>>> "SQ" == Sean Quinlan <[EMAIL PROTECTED]> writes:
SQ> On Wed, 2004-09-08 at 10:34, Aaron Sherman wrote: >> On Wed, 2004-09-08 at 00:17, Uri Guttman wrote: >> >> > use warnings should be here too. >> [...] >> > i like "_$method" better. >> [...] >> > i don't like using => like that. >> >> Uri, you're ripping the guy's code to shreds over minor points of >> syntactic sugar... I seem to remember that Perl's moto isn't "There's >> only one way to do it." SQ> I think perhaps Uri is channeling the old tech meetings, where the main SQ> portion of the gathering was in-depth code review, including traps and SQ> common syntax. And I don't think anyone has accused Uri of being the SQ> most diplomatic monger. =P why thank you! the code quality is usually more important than the coder's ego :) and my comments are suggestions (and i word them that way). i say "i (don't) like this" not "this is the only way to code it". >> > i can't get into the actual design or debugging but i hope my comments >> > are useful. >> >> He did ask for help specifically in two areas of the design, not a style >> lecture. Usually I'm not this harsh, but man, that's gotta make a guy >> feel like sending his code to this list is about the same as pulling his >> pants down in public! public posting of code is open to all sorts of comments. as i said, i don't have the time to get into his design and bug issues so i thought i would help out where i can. in some places (the parts you didn't quote) i made very useful recommendations (the ||= stuff in particular). SQ> While making recommendations on style can be useful, particularly in the SQ> cases where it can reduce the possibility of bugs, I would agree that SQ> approaching the main request of the poster first might be more SQ> appropriate. and i said i couldn't do that. it is too large and off my area of interest to get into its design. i am wary of the idea of using OO like that as well. when i see many utilities with similar options, i tend to think it would be better as one main utility with commands and options. that would remove both the code and doc redundancy. it could still be very modular (load modules based on the command selected). uri -- Uri Guttman ------ [EMAIL PROTECTED] -------- http://www.stemsystems.com --Perl Consulting, Stem Development, Systems Architecture, Design and Coding- Search or Offer Perl Jobs ---------------------------- http://jobs.perl.org _______________________________________________ Boston-pm mailing list [EMAIL PROTECTED] http://mail.pm.org/mailman/listinfo/boston-pm
