Hi,

Often lately when reviewing code I see...

...
use Exporter;    # I'd like this to be require Exporter maybe in BEGIN
...

our @ISA = 'Exporter';
our @EXPORT_OK = ...;

It bugs me because it fits neither of the two suggested styles at the
top of the Exporter pod (nor the use base or use parent alternatives),
and because I don't feel like it's appropriate to call Exporter's
import() function the way the 'use' above does. They should be using
require or else "use Exporter 'import'" like the docs say.

But I've already mentioned it one other time and my advice was ignored
IIRC. I guess Exporter's import is written so this is harmless, so maybe
I should let it go?


-- 
Mike Small
[email protected]

_______________________________________________
Boston-pm mailing list
[email protected]
http://mail.pm.org/mailman/listinfo/boston-pm

Reply via email to