Bill Ricker <[email protected]> writes:

> Non random statistical sample from my harddrive
> 3636 require Exporter;
>  1234 use Exporter;
>     404 use Exporter ();
>     338 require Exporter ;
>     239     require Exporter;
>     225     use Exporter   ();
>      90      require Exporter;
>      86 use Exporter 5.57 'import';
>      75 use Exporter 'import';
>      73   require Exporter;
>
> ​and many other spacing variations ...​ yeah i could canonicalize spacing
> but it's close
>
> ​Unless the doc's endorse the usage, it's a code smell at a minimum ... ​
> and even if endorsed the comment is a code smell.

And yet one that 1234 common modules have if I understand your output
correctly.  Hmmm, maybe I'll mention it one more time and then let it go.

-- 
Mike Small
[email protected]

_______________________________________________
Boston-pm mailing list
[email protected]
http://mail.pm.org/mailman/listinfo/boston-pm

Reply via email to