Notify the bridge module when a user changes the bridge-binding flag
of a VLAN interface using "ip link set ... vlan bridge_binding on"
command, so that the bridge module can take the appropriate action for
this change.

Signed-off-by: Sevinj Aghayeva <[email protected]>
---
 net/8021q/vlan.h     |  2 +-
 net/8021q/vlan_dev.c | 20 +++++++++++++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/net/8021q/vlan.h b/net/8021q/vlan.h
index 5eaf38875554..71947cdcfaaa 100644
--- a/net/8021q/vlan.h
+++ b/net/8021q/vlan.h
@@ -130,7 +130,7 @@ void vlan_dev_set_ingress_priority(const struct net_device 
*dev,
 int vlan_dev_set_egress_priority(const struct net_device *dev,
                                 u32 skb_prio, u16 vlan_prio);
 void vlan_dev_free_egress_priority(const struct net_device *dev);
-int vlan_dev_change_flags(const struct net_device *dev, u32 flag, u32 mask);
+int vlan_dev_change_flags(struct net_device *dev, u32 flag, u32 mask);
 void vlan_dev_get_realdev_name(const struct net_device *dev, char *result,
                               size_t size);
 
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index e1bb41a443c4..7c61b813e654 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -22,6 +22,7 @@
 #include <linux/skbuff.h>
 #include <linux/netdevice.h>
 #include <linux/net_tstamp.h>
+#include <linux/notifier_info.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/phy.h>
@@ -211,8 +212,9 @@ int vlan_dev_set_egress_priority(const struct net_device 
*dev,
 /* Flags are defined in the vlan_flags enum in
  * include/uapi/linux/if_vlan.h file.
  */
-int vlan_dev_change_flags(const struct net_device *dev, u32 flags, u32 mask)
+int vlan_dev_change_flags(struct net_device *dev, u32 flags, u32 mask)
 {
+       struct netdev_notifier_change_details_info details;
        struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
        u32 old_flags = vlan->flags;
 
@@ -223,19 +225,31 @@ int vlan_dev_change_flags(const struct net_device *dev, 
u32 flags, u32 mask)
 
        vlan->flags = (old_flags & ~mask) | (flags & mask);
 
-       if (netif_running(dev) && (vlan->flags ^ old_flags) & VLAN_FLAG_GVRP) {
+       if (!netif_running(dev))
+               return 0;
+
+       if ((vlan->flags ^ old_flags) & VLAN_FLAG_GVRP) {
                if (vlan->flags & VLAN_FLAG_GVRP)
                        vlan_gvrp_request_join(dev);
                else
                        vlan_gvrp_request_leave(dev);
        }
 
-       if (netif_running(dev) && (vlan->flags ^ old_flags) & VLAN_FLAG_MVRP) {
+       if ((vlan->flags ^ old_flags) & VLAN_FLAG_MVRP) {
                if (vlan->flags & VLAN_FLAG_MVRP)
                        vlan_mvrp_request_join(dev);
                else
                        vlan_mvrp_request_leave(dev);
        }
+
+       if ((vlan->flags ^ old_flags) & VLAN_FLAG_BRIDGE_BINDING &&
+           netif_is_bridge_master(vlan->real_dev)) {
+               details.info.dev = dev;
+               details.vlan.bridge_binding =
+                   !!(vlan->flags & VLAN_FLAG_BRIDGE_BINDING);
+               call_netdevice_notifiers_info(NETDEV_CHANGE_DETAILS, 
&details.info);
+       }
+
        return 0;
 }
 
-- 
2.34.1

Reply via email to