On Tue, Sep 20, 2022 at 5:16 AM Nikolay Aleksandrov <[email protected]> wrote:
> On 17/09/2022 23:17, Sevinj Aghayeva wrote: > > When bridge binding is enabled for a vlan interface, it is expected > > that the link state of the vlan interface will track the subset of the > > ports that are also members of the corresponding vlan, rather than > > that of all ports. > > > > Currently, this feature works as expected when a vlan interface is > > created with bridge binding enabled: > > > > ip link add link br name vlan10 type vlan id 10 protocol 802.1q \ > > bridge_binding on > > > > However, the feature does not work when a vlan interface is created > > with bridge binding disabled, and then enabled later: > > > > ip link add link br name vlan10 type vlan id 10 protocol 802.1q \ > > bridge_binding off > > ip link set vlan10 type vlan bridge_binding on > > > > After these two commands, the link state of the vlan interface > > continues to track that of all ports, which is inconsistent and > > confusing to users. This series fixes this bug and introduces two > > tests for the valid behavior. > > > > Sevinj Aghayeva (5): > > net: core: export call_netdevice_notifiers_info > > net: core: introduce a new notifier for link-type-specific changes > > net: 8021q: notify bridge module of bridge-binding flag change > > net: bridge: handle link-type-specific changes in the bridge module > > selftests: net: tests for bridge binding behavior > > > > include/linux/if_vlan.h | 4 + > > include/linux/netdevice.h | 3 + > > include/linux/notifier_info.h | 21 +++ > > net/8021q/vlan.h | 2 +- > > net/8021q/vlan_dev.c | 20 ++- > > net/bridge/br.c | 5 + > > net/bridge/br_private.h | 7 + > > net/bridge/br_vlan.c | 18 +++ > > net/core/dev.c | 7 +- > > tools/testing/selftests/net/Makefile | 1 + > > .../selftests/net/bridge_vlan_binding_test.sh | 143 ++++++++++++++++++ > > 11 files changed, 223 insertions(+), 8 deletions(-) > > create mode 100644 include/linux/notifier_info.h > > create mode 100755 > tools/testing/selftests/net/bridge_vlan_binding_test.sh > > > > The set looks good to me, the bridge and vlan direct dependency is gone and > the new notification type is used for passing link type specific info. > > If the others are ok with it I think you can send it as non-RFC, but I'd > give it > a few more days at least. :) > Okay, I will wait until the end of the week. Thanks! > > Thanks, > Nik > > -- Sevinj.Aghayeva
