When BROPT_FDB_LOCAL_VLAN_0 is enabled, the local FDB entries for the
member ports as well as the bridge itself should not be created per-VLAN,
but instead only on VLAN 0.

That means that br_handle_frame_finish() needs to make two lookups: the
primary lookup on an appropriate VLAN, and when that misses, a lookup on
VLAN 0.

Have the second lookup only accept local MAC addresses. Turning this into a
generic second-lookup feature is not the goal.

Reviewed-by: Ido Schimmel <[email protected]>
Signed-off-by: Petr Machata <[email protected]>
---
 net/bridge/br_input.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index 5f6ac9bf1527..67b4c905e49a 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -202,6 +202,14 @@ int br_handle_frame_finish(struct net *net, struct sock 
*sk, struct sk_buff *skb
                break;
        case BR_PKT_UNICAST:
                dst = br_fdb_find_rcu(br, eth_hdr(skb)->h_dest, vid);
+               if (unlikely(!dst && vid &&
+                            br_opt_get(br, BROPT_FDB_LOCAL_VLAN_0))) {
+                       dst = br_fdb_find_rcu(br, eth_hdr(skb)->h_dest, 0);
+                       if (dst &&
+                           (!test_bit(BR_FDB_LOCAL, &dst->flags) ||
+                            test_bit(BR_FDB_ADDED_BY_USER, &dst->flags)))
+                               dst = NULL;
+               }
                break;
        default:
                break;
-- 
2.49.0


Reply via email to