It would seem so :)

Thanks for your report.  I've submitted your suggested fix.


On Wed, Jan 29, 2003 at 12:56:47PM -0500, Dan Eble wrote:

> It looks like if there are no ports available, the memory pointed to by
> "p" is freed, but "dev->br_port" still points to it.  I have not tried to
> make it happen.  Shouldn't the assignment to "dev->br_port"  occur after
> the port structure is fully initialized?
> 
> 158  dev->br_port = p;
> 159
> 160  for (i=1;i<255;i++)
> 161      if (br_get_port(br, i) == NULL)
> 162          break;
> 163
> 164  if (i == 255) {
> 165      kfree(p);
> 166      return NULL;
> 167  }
> 
> -- 
> Dan Eble <[EMAIL PROTECTED]>  _____  .
>                            |  _  |/|
> Applied Innovation Inc.    | |_| | |
> http://www.aiinet.com/     |__/|_|_|
> 
> _______________________________________________
> Bridge mailing list
> [EMAIL PROTECTED]
> http://www.math.leidenuniv.nl/mailman/listinfo/bridge
_______________________________________________
Bridge mailing list
[EMAIL PROTECTED]
http://www.math.leidenuniv.nl/mailman/listinfo/bridge

Reply via email to