Hi Ate, Thank you for the proper advice. Since each solution(proposing it to MyFaces and proposing to Portal Briges) has the benefit, actually, I hovered between them. For me, the easy way was to propose it to Portal Bridges. So, I did that.. But, as you mentioned, since MyFaces team may be interested in it, I should have proposed it to MyFaces first. Anyway, I'll contact to MyFaces team.
Some components, such as inputHtml, use AddResource class to handle some tags in <head>. Therefore, if you want to use it, you have to use ExtensionsFilter in portal's web.xml or to manage the tags in <head>. IMO, I do not think ExtensionsFilter is proper in Portlet. So, in my suggestion, MyFacesGenericPortlet handle the tag to support the components. Regards, shinsuke Ate Douma wrote: > Shinsuke, > > First of all, I didn't checkout yet the source of your bridge but I don't > think it is very relevant for the points I'd like to make. > > I'm not flat out opposed to what you're asking but not fully +1 either. > For one, the MyFaces project is proving JSR-168 support already (as opposed to > for instance Struts) and my first suggestion would be trying to get it > integrated > into their own JSR-168 support. > Your reasons for not doing so I can understand though, and if the MyFaces > would > not be interested at all or even opposed to your suggestions I probably will > say: go ahead. > But maybe they *are* interested and would like to incorporate your > enhancements. > If so, then further improvements/fixes most likely will be welcomed as well. > I know David Le Strat worked with the MyFaces team and got fixes/enhancements > for the > Tree component incorporated too (he probably can elaborate on that if you'd > like). > Furthermore, from your description below I get the impression (correct me if > wrong) > that your enhancements will create a hard dependency on MyFaces, meaning > the JSF Bridge actually would become a MyFacesBridge. Correct? > I'd be surely hesitant about that. > > I think I would prefer to work (much) more closely together with the MyFaces > team to > have them provide a great JSR-168 implementation and support. > In the end, both our teams and our end users will have the more benefit from > that. > > Regards, > > Ate > > Shinsuke SUGAYA wrote: > >>Hi all, >> >>I would like to propose the portal bridge for MyFaces >>though Portals Bridges has JSF bridge. I have already >>created MyFaces bridge in SourceForge.jp, and put the >>source code to: >> >>http://cvs.sourceforge.jp/cgi-bin/viewcvs.cgi/jetplume/jetplume/bridges/myfaces/ >> >>I would like to integrate the above code to Portals Bridges >>after changing the classpath. >> >>This bridge was enhanced based on MyFaces' MyFacesGenericPortlet, >>and it has the following features: >> >>- Supports components which use <script> and <link> tags >> in <head> tag. The components, such as inputHtml, work >> on J2 *without* o.a.myfaces.component.html.util.ExtensionsFilter >> in the portal's web.xml. J2 has JS2-316 right now, and >> it will be fixed by this bridge. For other portals, if >> it has a mechanism like J2's HeaderResource component, >> I will be able to implement this feature. >>- Supports <x:fileUpload/> component. >>- Added some minor fixes. >> >>Since this bridge supports tags in <head>, it becomes >>MyFaces' specific one. >> >>I have a way to propose this fix to MyFaces project. But >>since I have the following things, I did that to Portal Bridges. >> >>I would like to.. >>- provide it at the independent release cycle from MyFaces. >>- continue to enhance and fix it. >> >>If we can agree on this proposal, I'd like to put this >>bridge to Portals Bridges. >> >>Any comments/suggestions are highly appreciated. >> >>Regards, >> shinsuke >> >> >> >> >> >>__________________________________ >>Save the earth >>http://pr.mail.yahoo.co.jp/ondanka/ >> >> >>--------------------------------------------------------------------- >>To unsubscribe, e-mail: [EMAIL PROTECTED] >>For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> >> >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > __________________________________ Save the earth http://pr.mail.yahoo.co.jp/ondanka/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
