Did Bob catch this by encountering the error or just by seeing the calculation and realizing it was wrong? Is there a way to get to that with a non-normalized vector? Basically, is it user-visible? :)
Cheers! Sean On Aug 13, 2012, at 1:54 PM, [email protected] wrote: > Revision: 51964 > http://brlcad.svn.sourceforge.net/brlcad/?rev=51964&view=rev > Author: starseeker > Date: 2012-08-13 17:54:51 +0000 (Mon, 13 Aug 2012) > Log Message: > ----------- > Correct formula for obliquity in nirt - this will only be visable if the > normal vector isn't unitized. Bob caught this. > > Modified Paths: > -------------- > brlcad/trunk/src/nirt/if.c > > Modified: brlcad/trunk/src/nirt/if.c > =================================================================== > --- brlcad/trunk/src/nirt/if.c 2012-08-13 17:37:34 UTC (rev 51963) > +++ brlcad/trunk/src/nirt/if.c 2012-08-13 17:54:51 UTC (rev 51964) > @@ -309,7 +309,7 @@ > fastf_t cos_obl; > fastf_t obliquity; > > - cos_obl = fabs(VDOT(ray, normal) * MAGNITUDE(normal) / MAGNITUDE(ray)); > + cos_obl = fabs(VDOT(ray, normal) / (MAGNITUDE(normal) * MAGNITUDE(ray))); > if (cos_obl < 1.001) { > if (cos_obl > 1) > cos_obl = 1; > > This was sent by the SourceForge.net collaborative development platform, the > world's largest Open Source development site. > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > BRL-CAD Source Commits mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/brlcad-commits ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
