On Oct 23, 2013, at 6:37 AM, Daniel Roßberg wrote: > I would like to have a CMake variable to switch it off. I'm afraid > MSVC needs another day to compile with this check because of slow file > operations.
Thanks to Cliff, a style validation option now exists. It would be good to know exactly how much overhead the validation is going to cost, but there definitely needs to be a reliable way to turn this feature off. We'll need to give trunk some time to settle, though, as it has gotten a bit unstable to test much more without resolving several open issues. >> To that same end, I think it's time to eliminate this common source of >> discussion too. Unless there's an objection, I propose and plan to update >> all sources to only use spaces for indentation. This will preserve our >> current appearance and indent level. This is the more portable and >> patch-friendly option as well. It coincidentally matches the Apache style >> guide, though that is just an observation, not a consideration. > > +2 :) The polling was not a majority (only 40%) representation, but does support a move to 4-char space indentation. I'll be making this change *after* trunk settles down a little bit, after a few more patches are applied, and after some more testing with astyle is completed. Note that this will cause nearly all outstanding patches to conflict, so please review and apply as many as possible as soon as possible. Cheers! Sean ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
