I propose in advance of GCI that we establish style enforcement as part of the
build so that we don't have to personally discuss / explain style issues.
Basically, we'd integrate a style check that would run during compilation. If
a file fails our style check, it results in a compilation error.
The reason for doing it this way is not just to reduce the discussion overhead,
but to reinforce the notion that this is one of our code quality requirements
and not just a particular developer being picky. Plus, I think new devs that
have a hard time with this concept are less likely to be offended or depressed
when it's a tool telling them it's wrong. We can just ask them if it compiles
or point out that it doesn't.
To that same end, I think it's time to eliminate this common source of
discussion too. Unless there's an objection, I propose and plan to update all
sources to only use spaces for indentation. This will preserve our current
appearance and indent level. This is the more portable and patch-friendly
option as well. It coincidentally matches the Apache style guide, though that
is just an observation, not a consideration.
Changing to spaces will come at the expense of an approximate 5.41MB (~1%)
increase to the checkout size (I counted 804916 tabs at the beginning of lines).
If anyone would like to alternatively and collectively have the core devs
consider either tabs-only or 2-char space indents, send me a note back in
private and I'll put our options to a quick vote before making a change.
Cheers!
Sean
p.s. Here's the indentation level histogram I observed across our src/ files:
114988 :
70350 ::
1785 :::
1915 ::::
72298 :::::
23106 ::::::
1545 :::::::
2535 ::::::::
1175 :::::::::
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
