On Fri, Dec 6, 2013 at 11:56 PM, Christopher Sean Morrison <[email protected]> wrote: > Couple points, I'll try to make them brief. > On Dec 6, 2013, at 4:20 PM, [email protected] wrote: > >> --- brlcad/trunk/src/rt/heatgraph.c 2013-12-06 21:18:17 UTC (rev 58859) >> +++ brlcad/trunk/src/rt/heatgraph.c 2013-12-06 21:20:14 UTC (rev 58860) >> @@ -147,9 +147,9 @@ >> if (timeTable == NULL) { >> + timeTable = (fastf_t **)bu_malloc(x * sizeof(double *), >> "timeTable"); >> for (i = 0; i < x; i++) { >> - timeTable[i] = bu_malloc(y * sizeof(double), "timeTable[i]"); >> + timeTable[i] = (fastf_t *)bu_malloc(y * sizeof(double), >> "timeTable[i]"); > > It's always a big red flag when an *alloc() sizeof type does not match the > return cast type. > That was also observed in the prior commit that r58863 fixed. ... > I suggest hitting up ws/style changes as a commit per dir either before > working changes in that dir or > after you're done committing some code change(s). > That way all files in a dir get hit up consistently too. ...
All mea culpa! Trying to go too fast and getting sloppy. Good points made and will be attended to, -Tom ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
