On Sat, Dec 7, 2013 at 12:26 AM, <[email protected]> wrote: > Revision: 58872 > http://sourceforge.net/p/brlcad/code/58872 > Author: brlcad > Date: 2013-12-07 06:26:06 +0000 (Sat, 07 Dec 2013) > Log Message: > ----------- > revert r58866 because not all of our hooked functions have that signature > (see dsp.c for example). might be possible to make them all match,
I did a naive search for sp_hook functions (I didn't think of the bu_structparse data tables) and only found four. Their signatures match except for slight variations in constness. This morning a more thorough search turned up about 100 files that are using sp_hook functions. If I find one or more with differing signatures, what should I do? My guess is: I should rework them to fit a common signature, even though they may have one or more UNUSED(x) wrappers around func args. Best regards, -Tom ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
