The idea was that removing the unnecessary structs will considerably reduce the lines of code. This will eliminate possible sources of error and make it easier to test and review the remaining functions.
Daniel 2014-03-13 21:59 GMT+01:00 Clifford Yapp <cliffy...@gmail.com>: > On Thu, Mar 13, 2014 at 1:05 PM, 赵安清 <zaqcl...@hotmail.com> wrote: >> Daniel and Clifford, >> >> Hi, thanks sincerely for your kindness and suggestions. >> >> I have read raytrace.h, nmg.h, given email list and some other info. Are we >> almostly sure that model and nmgregion are exactly useless and should >> be removed? And If I do so, how about the places (I don't know how much >> exactly) using them. All such places should be done the corresponding >> modification...or maybe I needn't concern about this thing now? > > My sense is that we don't need to immediately worry about removing > them - after the library is properly stand-alone and the lower level > routines have been thoroughly tested (both of which are immediately > necessary for libnmg to be useful) we can consider whether they are > worth keeping. > >> But I think seperating them into serveral header files reasonably maybe >> better than one. If someone think it's too tedious to include 'so many' >> headers, we can provide an extra header file just including all the others >> and users just need to use this one alone. > > Absolutely. If you look at libbu, you'll see we're beginning exactly > that process for our other libraries as well - that sounds like a very > good idea. > >> And, can I consider these two tasks as the first and second step of 'Mesh >> Library Cleanup' project respectly? > > How you structure your proposal is ultimately up to you - my > recommendation would be to not worry about removing the "top level" > structures immediately unless it proves too difficult to work properly > with libnmg without doing so - I would start by "properly" extracting > libnmg from librt and follow on with the header breakout, moving from > there to doxygen documentation + test harness setup - but that's just > my opinion. > > CY > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > BRL-CAD Developer mailing list > brlcad-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/brlcad-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
