On Tue, Apr 28, 2015 at 3:40 AM, Christopher Sean Morrison <brl...@mac.com>
wrote:
> On Apr 27, 2015, at 5:48 PM, Vasco Alexandre da Silva Costa <
> vasco.co...@gmail.com> wrote:
>
> I made a couple of patches. One fixes compilation errors and refactors the
> OpenCL SPH (sphere) shot code. The other patch adds OpenCL EHY (Elliptical
> Hyperboloids) shot support. All of this code is located in librt.
>
> https://sourceforge.net/p/brlcad/patches/341/
> https://sourceforge.net/p/brlcad/patches/346/
>
>
> I did a quick review a month ago and they looked good, but I couldn’t
> compile-test them at the time — that’s the main reason they’re still
> pending. Soon as someone can give them the attention they deserve, they’ll
> get reviewed and applied.
>
Ok. To test the patches you need to enable OpenCL when you run CMake to
generate the makefiles. It took me a while to figure out how those settings
worked. You also need OpenCL.
I use the NVIDIA (OpenCL 1.1) implementation on Ubuntu Linux. The packages
come with the distro. If you do not have a NVIDIA card the AMD APP SDK
(OpenCL 2.0) implementation, downloadable from developer.amd.com, can run
on any x86 CPU and should be pretty feature complete. Much better than
NVIDIA's. Intel also has an implementation which should be feature complete
as well.
Is there a specific person who usually works or is the de facto maintainer
of librt? I see Erik and Sean (i.e. you) as mentors in the GSoC page. Most
of the recent commits in librt seem to haven been done by Starseeker.
> PS: I am going to work on OpenCL RT support for GSoC 2015. So I don't know
> what is more viable, if someone will apply the patches for me, or if you
> give me commit access and then I commit them myself. I am experienced with
> using SVN. I used to be a Freeciv (FLOSS strategy game you can find on
> sf.net) maintainer.
>
> HACKING file covers our commit policy. Basically, it’s patches until
> you’re offered commit access. Everyone needs at least two substantial. If
> the patches are perfect, you’re probably good to go.
>
Ok. It makes sense. Just mail me if you guys have any questions or
suggestions.
Thanks,
--
Vasco Alexandre da Silva Costa
PhD Student at Department of Information Systems and Computer Science
Instituto Superior Técnico/University of Lisbon, Portugal
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
