Shubham,
> Sir, if you could review the anno.c patch, it would be helpful. I'll rectify
> errors otherwise I'll jump onto the next task.
Some comments after a short review of your patches:
- You created a lot of patch files, one for each source file. They
are hard to handle, e.g. I had to find or create the corresponding
directories, and incomplete, e.g. the changes to CMakeLists.txt are
missing. Please, create one patch file containing everything needed.
- You wrote in your log that "annotation" is too long and replaced it
by "anno". I would name it "annot" because of a possible confusion.
See
http://www.dictionary.com/browse/anno
http://www.dictionary.com/browse/annotation
http://www.dictionary.com/browse/annot
- Aim for formal correctness regarding the coding style. E.g. indents
(anno.c line 78 or 1781 et seqq.), consistent number of line feeds
between the functions, no trailing spaces. When your patch is
formally correct I can check it in.
Regards,
Daniel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
