Sir,
I modified the structure :
static char *p_annot[] = {
"Enter the point to be annotated: ",
"Enter Y: ",
"Enter Z: ",
"Enter the text label: ",
"Enter X,Y for the text placement: ",
"Enter Y: ",
"Enter the relative vertical position(1->bottom, 2->middle, 3->top): ",
"Enter the relative horizontal position(1->right, 2->center, 3->left):
",
"Enter the number of points in the VL: ",
"Enter the points: ",
"Enter the number of segments in the SL: ",
"Enter the segments: "
};
Where I expect the user to give the SL input something like this:
SL {
{ line S 0 E 1 }
{ carc S 2 E 1 R -1 L 0 O 0 }
{ bezier D 3 P { 1 3 4 5 } }
{ carc S 5 E 6 R 1.644755298192071224505639 L 0 O 0 }
{ line S 6 E 7 }
{ bezier D 6 P { 7 8 9 10 11 12 0 } }
}
suggestions !
Regards,
Shubham Rathore(:gabbar1947)
On Thu, Jun 15, 2017 at 9:59 PM, Shubham Rathore <
shubhamrathore1...@gmail.com> wrote:
> Hi Sir,
>
>
>> Some comments after a short review of your patches:
>> - You created a lot of patch files, one for each source file. They
>> are hard to handle, e.g. I had to find or create the corresponding
>> directories, and incomplete, e.g. the changes to CMakeLists.txt are
>> missing. Please, create one patch file containing everything needed.
>>
> Will do it now !
>
>
>> - You wrote in your log that "annotation" is too long and replaced it
>> by "anno". I would name it "annot" because of a possible confusion.
>> See
>> http://www.dictionary.com/browse/anno
>> http://www.dictionary.com/browse/annotation
>> http://www.dictionary.com/browse/annot
>>
> Oh! I see, I'll update the code. Actually the statement in magic.h
> ,"#define RT_ANNOTATION_INTERNAL_MAGIC 0x616e66f /**< anno */ "
> made me rename it anno, but now I get it !
>
> - Aim for formal correctness regarding the coding style. E.g. indents
>> (anno.c line 78 or 1781 et seqq.), consistent number of line feeds
>> between the functions, no trailing spaces. When your patch is
>> formally correct I can check it in.
>
> Apologies for that! I'll do it as soon as possible.
>
> Regards,
> Shubham Rathore(:gabbar1947)
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
