Hi,
Sean has left the following comment at Fix Mac OS X compilation errors
under Buildbot
http://www.google-melange.com/gci/task/view/google/gci2012/8081208:
hmm.
Looks better except that it's generally more desirable to test for features
that to test for platforms, compilers, or similar "generalizations". That
is to say that you probably don't need the CMAKE_C_COMPILER_ID
MATCHES "Clang" protection since if a compiler supports that warning
option, then we probably want to use it.
HOWEVER, the other issue is that the warning is being addressed by turning
off the warning! That's generally not our practice. At least, not without
first investigating and exhausting all other options. Without that attempt,
turning off the warning is wrong.
That's a relatively new warning flag to me that I've not yet researched in
depth. My cursory understanding is that it will warn if we take the offset
of an "extended" field specification, like that magic offset in the other
patch. What's an actual error that comes up if you leave the warning
enabled?
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Fix Mac OS X
compilation errors under Buildbot.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2012/8081208.
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
