Hi,
Sean has left the following comment at Calculate plate-mode triangle mesh
(BOT) surface areas
http://www.google-melange.com/gci/task/view/google/gci2012/8088204:
hmm.
Can you explain what your first loop is doing? "transferring data" doesn't
really seem to convey much behind the intent nor address several
peculiarities in that loop... :)
A few pragmatic issues:
shouldn't use // comments -- did you disable strict mode? the build should
be reporting those as problems to you. use /* comment */
mixed tabs and spaces for indentation. you used only spaces. We use hybrid
spacing where it's 4spaces, then 1 tab, the 1tab and 4 spaces, then 2 tabs,
etc. See our HACKING file or other sections of the file you're editing for
examples. We provide emacs local variables and vim modelines to format it
automatically with those editor environments, but you may have to set your
environment up manually (tabstop=8, indent=4)
braces should be on same line -- you have a bunch of if statements near the
end
lenghts is spelled wrong
what's the purpose of INTCLAMP() in the first loop?
why aren't you using bn_area_of_triangle() ? :) You should reuse existing
API as much as possible (see include/bn.h and other headers)
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Calculate
plate-mode triangle mesh (BOT) surface areas .
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2012/8088204.
------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
