Hi,

Sean has left the following comment at Calculate plate-mode triangle mesh (BOT) surface areas http://www.google-melange.com/gci/task/view/google/gci2012/8088204:


now that's a patch


Very nice work Johannes. We'll likely have a follow-on task to enable this new function and properly test it, but the implementation looks pretty good now. We'll be sure to credit you in our authorship notes on this one.

I only noticed a couple issues, but they're minor in the scope of effort you've put in on the patch. I noticed was the assumption that "default" is one of the RT_BOT_PLATE* modes, which won't necessarily always be true. The code should be explicit and default to same as RT_BOT_SOLID. The other issue I noticed is a curious lack of += *= etc operators. It's clearly called for in the accumulation of whole_bot_overall_area, for example, and a few other places.

Still, in all very nice use of the bn functions and hopefully validation will show that you got everything right! :)


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Calculate plate-mode triangle mesh (BOT) surface areas . To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/8088204.

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to