Hi,

Sean has left the following comment at Compile with -Wwrite-strings, fix warnings that ensue http://www.google-melange.com/gci/task/view/google/gci2012/8090205:


wrong way to quell


Your patch by large looks great but there is a problem that prevents the patch from being used. Casting string literals to (char *) is no good.

That tells the compiler that it's okay to allow that memory to be edited, and that's generally a bad thing. That's why the compiler is warning in the first place. The "fix" is usually to make the recipient const. If the setee really is needing to edit the string, then we need to know about those cases an review them on a case-by-case basis to see what's going on.

We can create a follow-up task so you can keep working on this if you've worked more than a few hours already (ie, scope is off). How long did you work on this?


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Compile with -Wwrite-strings, fix warnings that ensue. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/8090205.

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to