Hi,
brlcad has left the following comment at Create an utility library (LIBBU)
API unit test for bomb.c
http://www.google-melange.com/gci/task/view/google/gci2014/6449379632218112:
few issues
Marc,
This looks pretty good and the approach is sound, but there are a few minor
problems with the patch that you should fix before we can call this done.
First is the extraneous content in the patch file. We use tools that
automatically make the changes prescribed within a patch file, so if you
include extra stuff, we get those extra changes made and then we have to
spend time undoing them. It's far better and easier and less time to
everyone all around if you fix the problem on your end. You can either 1)
revert the changes to those files - svn revert -R src/libbn, or 2) only
create a patch file of the files you modified - svn diff src/libbu >
my.patch, or 3) edit your patch file and remove the offending content -
remove everything from an Index line to just before the next Index line.
Second issue is the inconsistent style in the file. You don't need to
conform to our rather rigorous style guide for GCI (see HACKING file if you
would like to conform, and required to attain commit rights), but the file
should at least be self-consistent. For example, in some places you put
curly braces on the next line and in other places you put it on the same
line; in some places you have spaces after commas and in others you do not;
etc. If you want a quick helper, just look at any of our other files.
Third, you're including far too many headers. Only include those that you
directly need. You definitely don't use stdarg.h, debug.h, and undoubtedly
several others.
Lastly is the issue of portability. This file will result in a compilation
failure on Windows. At a minimum, you'll want to wrap the unistd.h header
in a #ifdef HAVE_UNISTD_H wrapper along with the entire contents of the
test_bu_exit() function.
ps your coding skills are getting noticeably better...
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Create an
utility library (LIBBU) API unit test for bomb.c.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2014/6449379632218112.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
