Hi,
brlcad has left the following comment at Create an utility library (LIBBU)
API unit test for bomb.c
http://www.google-melange.com/gci/task/view/google/gci2014/6449379632218112:
not valid
Marc,
Looking better, but the introduction of platform-specific preprocessor
symbols will break our build (we don't allow the addition of any without
simultaneous removal). You don't need to check for windows (and testing for
windows is not correct anyways). Windows was but an example in my first
reply. It's can really all be made contingent on HAVE_UNISTD_H being
defined.
Consequently, you also pulled the include for unistd.h down into the
test_bu_exit() function which is syntactically incorrect (this should have
even given you an error.
You want to test that this unit test works both with and without
unistd.h .. you can do that by temporarily adding a #undef HAVE_UNISTD_H
after all the headers and making sure it gets to the fallback case (then
removing the #undef).
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Create an
utility library (LIBBU) API unit test for bomb.c.
To stop receiving these messages, go to:
http://www.google-melange.com/gci/task/view/google/gci2014/6449379632218112.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
