Hi,
rossberg has left the following comment at Write CoreInterface unit test #3
https://www.google-melange.com/gci/task/view/google/gci2014/5900674122383360:
None
First you should reduce your code by eliminating code duplication. You may
already have noticed that it would be nice to have a function (or better an
operator) to compare vectors. The reason for not defining such an operator
in cicommon.h is that the core interface is designed to be used as a
library in other programs. These programs usually already have a powerful
math library I don't want to mess up.
Don't rely on class name being "Cone", but ClassName() has to be Type(). In
fact the pointers have to be the same. This is what you test with ==,
otherwise you had to use strcmp() for example. Where these pointers point
to isn't important for the usage of the library but a meaningful string
makes the debugging or logging easier.
You should tests the standard constructor for creating a valid cone.
To reduce the confusion in coding style the tests of the primitives are
using the style described in brlcad/trunk/HACKING. Ie no need to use
capital letters in file names. And you should review the spaces in your
patch.
Greetings,
The Google Open Source Programs Team
---
You are receiving this message because you are subscribed to Write
CoreInterface unit test #3.
To stop receiving these messages, go to:
https://www.google-melange.com/gci/task/view/google/gci2014/5900674122383360.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker
