Hi,

tannousmarc has left the following comment at Write CoreInterface unit test #3 https://www.google-melange.com/gci/task/view/google/gci2014/5900674122383360:


Fixes


Coding style : Braces for functions go on the next line, braces for everything else, same line. Function returns go on a separate line for visibility. All functions have a comment saying which test scenario they are for, main is also documented. All the functions are static, to be used only in this file. Function names are mixed lowercase and uppercase, for when new words begin. Local variables are decalred near their usage. Variables have a meaningful name, easy to understand. C++ Stream I/O is used instead of C standard I/O.

File Name : Fixed, now not capitalized.

Valid Cone : Cones are now validated before being added to the database, there is no way an invalid cone can pass the test.

Pointer Comparison : Now used strcmp() to compare the two char* outputs.

Code duplication : Added a static bool function which compares two Vector3Ds, was really useful in cleaning the code, now everything looks way better.

Hope this one is okay :)

Regards,

Marc


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Write CoreInterface unit test #3. To stop receiving these messages, go to: https://www.google-melange.com/gci/task/view/google/gci2014/5900674122383360.

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to