On Mon, Jun 03, 2013 at 21:31 +0000, you wrote:
> I put some misc. doc and typo fixes in topic/jsiwek/plugins-cleanup Merged, thanks! > Was there anything that makes use of analyzer::Tag::subtype yet? That's indeed not used yet. It's in preparation for BinPAC++ where a single class will provide a set of analyzers. > Maybe put some initial calls to BRO_PLUGIN_VERSION(1) for everything? > Just feels like that feature is going to be underused/forgotten unless > people see things are already explicitly using it. Generally I'm thinking for statically compiled plugins versions aren't really useful; starting to version them would probably be more confusing than helpful. I'm seeing versions primarily for later when we have shared libraries and people may start updating plugins independently of Bro itself. That said, the idea was to always set the version of static plugins to BRO_PLUGIN_VERSION_BUILTIN. That doesn't happen right now if I'm not mistaken. Need to take another look. Robin -- Robin Sommer * Phone +1 (510) 722-6541 * [email protected] ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org/robin _______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
