> > > http://cr.opensolaris.org/~sowmini/parsegoop
> > > http://zhadum.east/export/ws/sowmini/brussels/parsegoop/webrev
>
> has been updated with Meem's feedback from
>
> http://mail.opensolaris.org/pipermail/brussels-dev/2009-February/001189.html
>
> all comments have been accepted.
Great. A few follow-ups:
* 178-186, 188-190: Looking at this more, is there a need for
these declarations? Your changes don't seem to necessitate
them, and the code is ordered so that they're not needed.
* 302-303: Would prefer these be merged into a single line.
(Yes, it's still a bit gross, but see comments below).
* 306: Two spaces after the period, please :-)
* 307: The term (per the manpage) is "human-friendly mode". Yes,
it's cheesy.
Regarding the ofmt API, for ofmt_open():
Would recommend that the `parsable' boolean_t be generalized
into a flags field so that it's clear what "B_TRUE" means and
easier to extend in the future. (In general, we've found a
flags argument every useful in APIs like dlpi_open()).
Would recommend that the column width be an argument. The
caller can request a specific width or OFMT_DYNWIDTH or somesuch
to ask ofmt to use the width provided by ofmt_update_winsize()
calls.
--
meem
