On (02/12/09 02:11), Peter Memishian wrote: > > Looks like IPMPSTAT_NCOL can also go.
agreed. > > The new ipmpstat behavior doesn't quite sound like the old one. > Specifically, if I specify "ipmpstat -g" with no "-o", then the output is > always the same, regardless of how wide my terminal window is (it may lead > to line wraps if e.g. the terminal window is only 50 characters). This is > intentional, as otherwise there's a subtle environmental condition that > impacts what data the user can see. (That is, the IPMPSTAT_NCOL check in > ipmpstat.c is just a subtle way of determining what fields should be > displayed by "all" and the ones that should be displayed by default. Its > results are always the same, regardless of screen width.) > Agree with the change in behavior that you flag, but then I am puzzled about the IPMPSTAT_NCOL constraint itself. If I do "ipmpstat -pn" with the onnv version of ipmpstat, it truncates out the RTTDEV because the output goes over 80 columns. When I read this code, I assumed that the "80" came from the default 80x25 xterm size. But if the xterm is less than 80 columns, and "-o" is not specified, don't we want the code to recognize the new constraint correctly (otherwise the 80 looks a bit arbitrary)? --Sowmini
