On 04/10/09 12:06, Sowmini.Varadhan at Sun.COM wrote: > I decided to take a stab at > > 6601421 dladm set-linkprop should support multiple -p options > I probably fixed this with my putback for 6796069 <http://monaco.sfbay.sun.com/detail.jsp?cr=6796069> dladm set-linkprop for multiple props succeeds even if some values are invalid
I also propagated the same fix for create-vnic/vlan/aggr for consistency. > along with some related linkprop fixes, but when I looked into > dladm.c, was surprised to find that "dladm_parse_props()" is called > from do_create_aggr and do_create_vlan in addition to the > expected (by me, at least) do_create_vnic *linkprop functions. > > What happened here? Why do we pass in property lists for aggr and > vlan creation? Consistency with create-vnic. We've always allowed bandwidth specification with create-vnic and then added cpus and priority. > Even more confusing is the fact that the dladm usage string (emitted > when one types dladm with no args) does not have any hint of the > -p option for vlans and aggrs. At least that, needs to be fixed! That's a bug. -Mike -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/brussels-dev/attachments/20090410/17eb7ea5/attachment.html>
