On 04/10/09 12:42, Peter Memishian wrote: > > > along with some related linkprop fixes, but when I looked into > > > dladm.c, was surprised to find that "dladm_parse_props()" is called > > > from do_create_aggr and do_create_vlan in addition to the > > > expected (by me, at least) do_create_vnic *linkprop functions. > > > > > > What happened here? Why do we pass in property lists for aggr and > > > vlan creation? > > > > We support bandwidth/cpu etc. properties for vlans (via dladm > create-vlan - > > just like a vlan created by dladm create-vnic -v) and aggrs. > > Is there an inherent neeed to support this rather than just having the > admin do a set-linkprop afterwards? There's not an inherent need. It's due to a series of decisions made during Crossbow development.
- create-vnic has always had maxbw as an argument - cpus and priority are link properties like maxbw which can be set for vnics and physical links - all 3 properties should be converted to link property framework. (this was also done for flows) - aggrs and vlans can take properties at creation, just like a vnic. (this applies flows as well) -Mike
