On Wed, 2008-10-01 at 08:50 -0400, Sowmini.Varadhan at Sun.COM wrote: > Looking for code-reviewers of a couple of bugfixes at > > http://cr.opensolaris.org/~sowmini/dladm_bugfixes/
In dladm.c linkprop_is_supported(), comments are needed to explain why you need to ask for both the default and current values, as the code looks broken without further explanation. Why would a property return "not supported" when asked for its default value, but return a current value? Maybe the correct fix is to add a return code such as DLADM_STATUS_NODEFAULT. In other words, it's supported, but has no default value. On that note, what properties have no default value, and why not? -Seb
