On Wed, 2008-10-01 at 14:53 -0400, Sowmini.Varadhan at Sun.COM wrote: > On (10/01/08 14:32), Sebastien Roy wrote: > > > > In dladm.c linkprop_is_supported(), comments are needed to explain why > > you need to ask for both the default and current values, as the code > > looks broken without further explanation. Why would a property return > > "not supported" when asked for its default value, but return a current > > > > On that note, what properties have no default value, and why not? > > autopush is an example.
The default value is the empty list by definition though, and that's what you'd get back for the current value if you haven't set it to anything else, right? > In this case, there's no intrinsic default value for the > property.. > > > value? Maybe the correct fix is to add a return code such as > > DLADM_STATUS_NODEFAULT. In other words, it's supported, but has no > > default value. > > maybe DLADM_STATUS_UNDEFINED is a better error code? Sounds fine. -Seb
