> There is a lager issue here: should user space apps that issue the > DLDIOC*PROP ioctls need mac.h to get the property numbers, or > should drivers include dld.h?
I don't see an issue with user-space making use of <sys/mac.h> -- it'll ultimately be a public part of the GLDv3 API. On the other hand, having e.g. third-party GLDv3 drivers pulling in an implementation detail like <sys/dld.h> is a problem. (Note that user-space apps are otherwise insulated from the DLD namespace since e.g. DLDIOC*PROP is actually issued by libdladm on behalf of userland.) > > What happens if the name passed in is already a canonical ndd > > property? Is it just silently ignored? > > It would be ignored. I presume the same would be true if it attempted to register a framework link property name like "autopush"? If so, that seems dangerous since namespace collisions that may be introduced over time (e.g., as we grow the set of framework-native link properties) will go unreported, which may lead to unpredictable behavior. -- meem
