> Ok, I will send you an updated spec soon (by tomorrow), but > here is a summary of what I see as the updates: > > - s/DLD_PERM/MAC_PERM > - s/DLD_MAP/MAC_MAP > - MAC_PERM_* constants and MAC_MAP* constants will reside in > <mac.h> > - mention that the private prop implementation of non-canonical > ndd params must begin with a "_", and that the ndd shim > will strip out (or add in) the "_" prefix for > output (or input) names > > With this change, mac_register_private_prop() will indeed > register private props, so I don't think a name change is > warranted (meem?)
Seems fine to me. Regarding the `name' parameter to mac_register_priv_prop(): I presume the caller will not provide the `_', and the framework will internally add it? (And that a `dladm show-linkprop' would show the leading underscore?) > A separate CR shall be filed to track the following: > "The larger question of where the information related to > the DLD*PROP ioctls will reside, and how they shall be named > (none of which are changed by this case) shall be dealt with > in a separate case." -- meem
