On Mar 6, 2008, at 10:00 PM, Garrett D'Amore wrote: > Sowmini.Varadhan at Sun.COM wrote: >> On (03/06/08 11:26), Garrett D'Amore wrote: >> >>>> If the concern is around the lack of error reporting, the synopsis >>>> of mac_register_priv_prop can be changed to return an int, with 0 >>>> return status indicating success, and EEXIST indicating that the >>>> registered name is a duplicate. >>>> >>> Probably not of much value, IMO. (We need to be trying to wean >>> developers off of private properties and ndd, and if I can avoid >>> having >>> to have error checks in the driver, it will make for >>> shorter/cleaner/simpler code in the driver -- that's a good thing >>> IMO.) >>> >> >> I could not agree more. >> >> >>> I'd like to ensure that the "names" passed to mac_register_priv_prop >>> also start with an underscore. >>> >> >> And have mac_ndd shim strip out (or add in) the "_" prefix to retain >> compatibility with existing snv output (or input) for the same >> command? >> > > Actually, I'm still unconvinced about the need to support "private" or > "non-canonical" properties via ndd. I think that in the new world, > folks should use dladm, which includes a programmatic API via > libdladm. > > I know that ndd is widely used for MII properties (and perhaps MTU), > but > I remain unconvinced that the folks who are using it today or other > things would need to continue to do so given the option of a dladm > based > equivalent. >
I would like to add a big YES to the statement above! I don't understand why we put effort in maintaining compatibilty with a mistake we made in the past. Or is just to punish ourselves for making the mistake? From a admin perspective: In daily life, I build/configure backup environments for customers. These backups often make link issues come to surface. When this happens, I pursue autoneg first. If this can't happen, I use ndd to verify that changing the link configuration indeed cures the problem. If so and if we can modunload/restart, I apply the change permanently in driver.conf. Only if we can't modunload/restart I leave an ndd init script. I don't see ndd being used that much for configuring nics and I would love to see it "just go away" as soon as dladm is available. Joost > > _______________________________________________ > brussels-dev mailing list > brussels-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/brussels-dev -- Joost Mulders + email: joost.mulders at sun.com Technical Specialist + phone: +31-33-45-15701 Client Solutions + fax: +31-33-45-15734 Sun Microsystems + mobile: +31-6-5198-7268 -= Anything not done right, has to be done again =-
