Hi Sowmini, I am still reviewing your code and since I am busy with my moving to US, I am not sure whether I can finish the review before March 26th. So far I have only one question:
the fix of bug 6672490: I think you could simply change the Why don't simply change the second argument of get_linkduplex() and get_linkstate() from B_FALSE to B_TRUE? Thanks - Cathy > PSARC 2008/171 and PSARC 2008/175 (fasttracks for Brussels ndd-compat, > and for the "framework enhancements to get default") were approved > at the psarc meeting yesterday. I would like to kick off the code > review for this component. > > While I have selected a list of reviewers below that is based > on the folks who frequently make changes in overlapping areas, > I would like to get feedback from the entire community- please > send any review comments! > > Timer is set to expire March 26 2008. > > --Sowmini > > On (03/13/08 11:32), Sowmini.Varadhan at Sun.COM wrote: >> To: Cathy.Zhou at Sun.COM, Garrett.Damore at Sun.COM, Peter.Memishian at >> Sun.COM, >> ted.you at sun.com, Crisson.Hu at Sun.COM, miles.xu at sun.com >> >> >> Extnernal webrev: >> http://cr.opensolaris.org/~sowmini/nddcompat_review/ >> Internal webrev: >> http://zhadum.east/export/ws/sowmini/brussels/nddcompat_review >> >> cscopes: >> /net/zhadum.east/export/ws/sowmini/brussels/nddcompat-review/usr/src[/uts] >> >> >> Ideally I would like all the reviewers to review all the files >> but if you have time constraints, please minimally send feedback >> on the file list below: >> >> Cathy: >> - usr/src/cmd/dladm/dladm.c >> - usr/src/lib/libdladm/common/linkprop.c >> - usr/src/uts/common/io/dld/dld_drv.c >> - usr/src/uts/common/io/mac/mac.c >> - usr/src/uts/common/io/bge/bge_main2.c >> >> Garrett/Meem: >> - usr/src/uts/common/Makefile.files >> - usr/src/uts/common/io/dld/dld_drv.c >> - usr/src/uts/common/io/mac/mac.c >> - usr/src/uts/common/io/mac/mac_ndd.c >> - usr/src/uts/common/sys/dld.h >> - usr/src/uts/common/sys/mac.h >> - usr/src/uts/common/sys/mac_impl.h >> - usr/src/uts/intel/bge/Makefile >> - usr/src/uts/sparc/bge/Makefile >> >> Garrett/Ted/Crisson/Miles >> - usr/src/uts/common/io/bge/bge_impl.h >> - usr/src/uts/common/io/bge/bge_main2.c >> - usr/src/uts/common/io/bge/bge_ndd.c >> - usr/src/uts/intel/bge/Makefile >> - usr/src/uts/sparc/bge/Makefile >> > _______________________________________________ > networking-discuss mailing list > networking-discuss at opensolaris.org
