Hi Cathy, > Hi Sowmini, > > I am still reviewing your code and since I am busy with my moving to > US, I am not sure > whether I can finish the review before March 26th.
no problem- Seb mentioned this to me, and has offered to review the code, since you/meem are busy with moving. But any comments that you have are welcome, of course. > So far I have only one question: > > the fix of bug 6672490: I think you could simply change the Why > don't simply change the > second argument of get_linkduplex() and get_linkstate() from > B_FALSE to B_TRUE? You are right, that also looks like it would work. But would this work for devices that are not renamed? If yes, then why don't we always assume islink? --Sowmini
