[brussels-dev] [clearview-discuss] 2008/056 Brussels addendum

[Cathy Zhou]

Sowmini.Varadhan at Sun.COM wrote:
> I've updated 
> 
>   http://cr.opensolaris.org/~sowmini/rfe/
> 
> with the latest comments. I've still got to test this
> on my laptop but until then, please keep the review
> input coming..
> 
dladm.c:

  - line 1458: should be "VLAN" instead of "LAN".
  - Line 1701: why this is needed?
  - 1721-1722: these are not needed when (i == ginfo.lg_nports - 1).

linkprop.c:

  - Does "speed" apply for all media type or only ETHER and WIFI? If it is the 
former, I 
think in the do_get_rate_prop() function, the code would be:

        if (media == DL_WIFI)
                return (do_get_rate_common(pd, linkid, prop_val, val_cnt,
                    WL_DESIRED_RATES));

        return (dld_speed_get(pd, linkid, prop_val, val_cnt));

  - Line 1277: better to return DLADM_STATUS_PROPRDONLY.

Thanks
- Cathy