sowmini.varadhan at sun.com wrote:
> Webrev at
>
>
>>> http://cr.opensolaris.org/~sowmini/rfe/
>>>
>
> has been updated with comments from Cathy/Seb - please have
> another look.
>
Out of curiousity, why isn't link state recorded for links other than
DL_ETHER? For WiFi it could be recorded, although it has a more complex
link state mechanism (down, associated, authenticated, up).
For DLD_PROP_DEFMTU, I think "current link mtu" is confusing. The
problem is IP mtu versus link mtu. I'm not sure how to improve it, though.
For DLD_PROP_SPEED, I thought we agreed that speed would be in "bps" not
"Mbps". (linkprop.c:201) (Again, recall that 802.11b can have a speed
of 5.5Mbps.)
linkprop.c: Link 1259, the comment would be clearer as "we currently
cannot set the rate on wifi links" (double negative). Can we really
set the rate on anything other than DL_ETHER? Maybe an explicit
DL_ETHER test would be better?
bge_main2.c: You removed the ENOTSUP fix? Why?
The rest looks OK.
-- Garrett
> --Sowmini
>
>
>
>
> _______________________________________________
> brussels-dev mailing list
> brussels-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/brussels-dev
>
