> I am not sure what the issue is, but here's another patch rebased to > 4308da8159 Fix infinite loop with `TeX-previous-error'.
Thanks, that one works! (The earlier one had a spurious "g" at the left of line 413, but even deleting that didn't fix it for me.) Most issues have been resolved. I'll test on multiple monitors soon. A couple minor comments: - The buframe jumps around a bit while live editing (regardless of other settings). Could this be reduced somehow? (Not a big issue, and can be postponed to later patches if it's at all tricky.) - The comment ';;; preview-point customizations and variables' now seems obsolete (and many things in the section that it demarcates are unrelated to the new functionality). The remaining conceptual issue from my POV is that it is now quite difficult to describe what 'preview-leave-open-previews-visible' does. It was already complicated enough, and the docstring needs to be updated further to incorporate the effect of 'preview-always-show'. The best solution I've come up with is to split it into a couple settings (which was already on the table when the option was added, see https://lists.gnu.org/archive/html/bug-auctex/2024-04/msg00128.html, but was less pressing then). What do you think about the following? Rename 'preview-always-show' to 'preview-show-away-from-point', rename 'preview-point-where' to 'preview-at-point-placement', and split 'preview-leave-open-previews-visible' into 'preview-at-point-display' and 'preview-keep-image-during-regeneration', with behavior as follows: --8<---------------cut here---------------start------------->8--- (defcustom preview-show-away-from-point t "Show previews while point is outside their source. When non-nil, overlays away from point display as rendered previews. When nil, overlays away from point show the TeX source until point enters their source; then, the options `preview-at-point-display' and `preview-at-point-placement' apply." :group 'preview-appearance :type 'boolean) (defcustom preview-at-point-display 'icon "Display style while point is inside a preview overlay. Set this to `icon' to reveal the TeX placeholder glyph, or to `preview' to display the rendered image while point is present. The placement is determined by `preview-at-point-placement'." :group 'preview-appearance :type '(choice (const :tag "TeX icon" icon) (const :tag "Rendered preview" preview))) (defcustom preview-at-point-placement 'before-string "Where to place the at-point preview or icon relative to its source. [Remainder of docstring same as before]." :group 'preview-appearance :type ;; ...same as before... ) (defcustom preview-keep-image-during-regeneration t "Keep the last preview image visible during regeneration. If non-nil, a preview that was just edited retains its previous image while it sits in the disabled state instead of showing the construction icon. When nil, the icon appears until the refreshed image arrives." :group 'preview-appearance :type 'boolean) (defcustom preview-leave-open-previews-visible nil "Obsolete alias for the at-point display and flicker knobs. Setting this also sets `preview-keep-image-during-regeneration' to the same value, and sets `preview-at-point-display' to `preview' when non-nil." :group 'preview-appearance :type 'boolean :set (lambda (sym value) (set-default sym value) (set-default 'preview-keep-image-during-regeneration value) (set-default 'preview-at-point-display (if value 'preview 'icon)))) (make-obsolete-variable 'preview-leave-open-previews-visible "Use `preview-keep-image-during-regeneration' \ and `preview-at-point-display' instead." "14.2.0") --8<---------------cut here---------------end--------------->8--- Thanks, best, Paul _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
