Hi Al,
> However, one use case for `preview-leave-open-previews-visible` (V) is
> controlling if an icon is displayed in certain cases, e.g., when the
> preview is disabled after editing or when it is being re-generated,
> instead of the (outdated) preview. This use case is always relevant for
> all values of `preview-point-where` and `preview-always-show`.
Agreed so far (and indeed, the intent of "V" was simply to reduce
flicker with automatic previewing, which is likewise relevant for all
such values).
> The other point is that, currently, the placement of the icon itself is
> also determined by the value of `preview-point-where`. If we use a nil
> value to denote icons, then we would fix the placement of the icon which
> seems unnecessarily inconsistent with the new increased customization.
I see your point about increased customization, although I wonder about
the value of allowing flexible placement of the icon -- would any user
care to move it away from its default location, and why? I still see
your point and will think about it more.
>
>> I noticed the following issues (A), (B), (C):
> What emacs version you are using and what value of `preview-auto-reveal`
> (I mainly have my tests with it being set to `t`)?
I'm on a fairly recent Emacs master (28f0658d8f5 from Nov 15), using the
default value of preview-auto-reveal, with preview-auto-reveal-commands
customized to:
(czm-tex-edit-return tex-parens-backward-down-list
tex-parens-down-list
czm-tex-jump-back-with-breadcrumb
consult-register-load ace-window other-window
flymake-goto-prev-error flymake-goto-next-error
(key-binding [left]) (key-binding [right])
backward-char forward-char pop-to-mark-command
undo)
I have not tested with 'preview-auto-reveal' set to t.
>> (A) With
>>
>> (setq preview-always-show t)
>> (setq preview-point-where 'buframe)
>>
> I've seen this issue once, but I thought I already addressed it and I no
> longer see it. I also don't recognize the behaviour you describe since
> with these settings, calling `preview-at-point` updates the preview,
> yeets the cursor out of the source and the preview is shown inline until
> one enters it again whereupon it is shown in a buframe. Can you confirm
> and/or provide more details?
I use (setq preview-protect-point t), which I suspect accounts for the
difference you observe (but let me know if otherwise).
>
>> (B) With
>>
>> (setq preview-leave-open-previews-visible t)
>> (setq preview-always-show nil)
>> (setq preview-point-where 'buframe)
>>
>> Enter a generated preview, edit it, regenerate it in place (e.g., with
>> 'preview-at-point'), and then exit it. Both the tex source and the
>> preview remain visible (until the preview is regenerated, so let's
>> suppose automatic previewing is disabled).
>>
>
> I don't see this behaviour either, definitely not with buframe. Can you
> confirm again and provide more details (source)? The post-command-hook
> `preview-move-point` calls `preview--update-buframe` which should hide
> the buframe when the overlay at point does not have the buframe
> property, so exiting the source should hide the buframe unless there's a
> case I am not considering.
I haven't been able to reproduce this just now -- not sure what changed.
I'll try some more over the coming days.
Everything else you said sounds great (and I don't object to the
whitespace change, especially given, as you point out, that you're
modifying the same function). Thanks also for your clarifications in
the other message.
Thanks, best,
Paul
_______________________________________________
bug-auctex mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-auctex
